[V5] ARM: dts: Change i2s compatible string on exynos5250【转】
本文转载自:https://patchwork.kernel.org/patch/2845464/
Padmavathi VennaAug. 16, 2013, 4:26 a.m. UTC
This patch removes quirks from i2s node and change the i2s
compatible names. Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
--- Changes since V4:
- Mark Brown reverted the below two patches due to below build failure with
exynos_defconfig.
"ARM: dts: exynos5250: move common i2s properties to exynos5 dtsi"
"ARM: dts: Change i2s compatible string on exynos5250" build error:
DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
ERROR (phandle_references): Reference to non-existent node or label "pdma1"
ERROR (phandle_references): Reference to non-existent node or label "pdma1"
ERROR (phandle_references): Reference to non-existent node or label "pdma0"
ERROR (phandle_references): Reference to non-existent node or label "pdma0" But with out "ARM: dts: Change i2s compatible string on exynos5250" will break the i2s
driver. So posting this patch now and will take care of posting other patch later after dependent
patches got merged. arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
Comments
Olof JohanssonAug. 16, 2013, 4:48 a.m. UTC | #1
On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna <padma.v@samsung.com> wrote:
> This patch removes quirks from i2s node and change the i2s
> compatible names.
>
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> ---
>
> Changes since V4:
> - Mark Brown reverted the below two patches due to below build failure with
> exynos_defconfig.
> "ARM: dts: exynos5250: move common i2s properties to exynos5 dtsi"
> "ARM: dts: Change i2s compatible string on exynos5250"
>
> build error:
> DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
> ERROR (phandle_references): Reference to non-existent node or label "pdma1"
> ERROR (phandle_references): Reference to non-existent node or label "pdma1"
> ERROR (phandle_references): Reference to non-existent node or label "pdma0"
> ERROR (phandle_references): Reference to non-existent node or label "pdma0"
>
> But with out "ARM: dts: Change i2s compatible string on exynos5250" will break the i2s
> driver.
>
> So posting this patch now and will take care of posting other patch later after dependent
> patches got merged.
>
> arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index ef57277..376090f 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -405,7 +405,7 @@
> };
>
> i2s0: i2s@03830000 {
> - compatible = "samsung,i2s-v5";
> + compatible = "samsung,s5pv210-i2s"; Device tree reviewers, this is something to look out for in the
future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
others "samsung,<ip>-<chip>". I don't personally care much one way or
another, but it really should be consistent. -Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
kgene@kernel.orgAug. 16, 2013, 5:43 a.m. UTC | #2
Olof Johansson wrote:
>
> On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna <padma.v@samsung.com>
> wrote:
> > This patch removes quirks from i2s node and change the i2s
> > compatible names.
> >
> > Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> > ---
> >
> > Changes since V4:
> > - Mark Brown reverted the below two patches due to below build
> failure with
> > exynos_defconfig.
> > "ARM: dts: exynos5250: move common i2s properties to
exynos5
> dtsi"
> > "ARM: dts: Change i2s compatible string on exynos5250"
> >
> > build error:
> > DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
> > ERROR (phandle_references): Reference to non-existent node or
> label "pdma1"
> > ERROR (phandle_references): Reference to non-existent node or
> label "pdma1"
> > ERROR (phandle_references): Reference to non-existent node or
> label "pdma0"
> > ERROR (phandle_references): Reference to non-existent node or
> label "pdma0"
> >
> > But with out "ARM: dts: Change i2s compatible string on exynos5250" will
> break the i2s
> > driver.
> >
> > So posting this patch now and will take care of posting other patch
> later after dependent
> > patches got merged.
> >
> > arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
> > 1 files changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> > index ef57277..376090f 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -405,7 +405,7 @@
> > };
> >
> > i2s0: i2s@03830000 {
> > - compatible = "samsung,i2s-v5";
> > + compatible = "samsung,s5pv210-i2s";
>
> Device tree reviewers, this is something to look out for in the
> future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
> others "samsung,<ip>-<chip>". I don't personally care much one way or
> another, but it really should be consistent.
>
Hmm...I think, if "samsung,<ip name>-<ip version>" is possible, it would be
nice. I remember there are no versions in datasheet for some IPs but
something have like i2s and mfc. So "samsung,<ip>-<version>" is used for
only i2s and mfc. But actually there are versions for Samsung IPs, no
comments for that in datasheet. So I think, if Samsung can provide the
specific version of Samsung IPs, we can use that like other platforms. I
will prepare some table for that after meeting with Samsung hardware IP team
so that samsung platform use one format "samsung,<ip>-<version>". Thanks,
Kukjin --
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tomasz FigaAug. 16, 2013, 7:48 a.m. UTC | #3
Hi Olof, On Thursday 15 of August 2013 21:48:32 Olof Johansson wrote:
> On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna <padma.v@samsung.com>
wrote:
> > This patch removes quirks from i2s node and change the i2s
> > compatible names.
> >
> > Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> > ---
> >
> > Changes since V4:
> > - Mark Brown reverted the below two patches due to below build
> > failure with>
> > exynos_defconfig.
> >
> > "ARM: dts: exynos5250: move common i2s properties to
> > exynos5 dtsi"
> > "ARM: dts: Change i2s compatible string on exynos5250"
> >
> > build error:
> > DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
> > ERROR (phandle_references): Reference to non-existent node
> > or label "pdma1" ERROR (phandle_references): Reference to
> > non-existent node or label "pdma1" ERROR
> > (phandle_references): Reference to non-existent node or
> > label "pdma0" ERROR (phandle_references): Reference to
> > non-existent node or label "pdma0">
> > But with out "ARM: dts: Change i2s compatible string on exynos5250"
> > will break the i2s driver.
> >
> > So posting this patch now and will take care of posting other patch
> > later after dependent patches got merged.
> >
> > arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
> > 1 files changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > b/arch/arm/boot/dts/exynos5250.dtsi index ef57277..376090f 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -405,7 +405,7 @@
> >
> > };
> >
> > i2s0: i2s@03830000 {
> >
> > - compatible = "samsung,i2s-v5";
> > + compatible = "samsung,s5pv210-i2s";
>
> Device tree reviewers, this is something to look out for in the
> future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
> others "samsung,<ip>-<chip>". I don't personally care much one way or
> another, but it really should be consistent. Hmm, I just did a quick git grep over arch/arm/boot/dts and could not
really find the "samsung,<ip>-<chip>" pattern. Except MFC (and without Padma's patch also I2S), which used "samsung,<ip>-
<ip version>, all the compatible values I can see are based on
"samsung,<chip>-<ip>" pattern. I believe we discussed this issue several times already and finally agreed
to use "samsung,<chip>-<ip>" for any new compatible values. Best regards,
Tomasz
Tomasz FigaAug. 16, 2013, 7:53 a.m. UTC | #4
Hi Kukjin, On Friday 16 of August 2013 14:43:17 Kukjin Kim wrote:
> Olof Johansson wrote:
> > On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna
> > <padma.v@samsung.com>
> >
> > wrote:
> > > This patch removes quirks from i2s node and change the i2s
> > > compatible names.
> > >
> > > Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> > > ---
> > >
> > > Changes since V4:
> > > - Mark Brown reverted the below two patches due to below
> > > build
> >
> > failure with
> >
> > > exynos_defconfig.
> > >
> > > "ARM: dts: exynos5250: move common i2s properties to
>
> exynos5
>
> > dtsi"
> >
> > > "ARM: dts: Change i2s compatible string on
> > > exynos5250"
> > >
> > > build error:
> > > DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
> > > ERROR (phandle_references): Reference to non-existent node
> > > or
> >
> > label "pdma1"
> >
> > > ERROR (phandle_references): Reference to non-existent node
> > > or
> >
> > label "pdma1"
> >
> > > ERROR (phandle_references): Reference to non-existent node
> > > or
> >
> > label "pdma0"
> >
> > > ERROR (phandle_references): Reference to non-existent node
> > > or
> >
> > label "pdma0"
> >
> > > But with out "ARM: dts: Change i2s compatible string on exynos5250"
> > > will>
> > break the i2s
> >
> > > driver.
> > >
> > > So posting this patch now and will take care of posting other patch
> >
> > later after dependent
> >
> > > patches got merged.
> > >
> > > arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
> > > 1 files changed, 3 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> >
> > b/arch/arm/boot/dts/exynos5250.dtsi
> >
> > > index ef57277..376090f 100644
> > > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > > @@ -405,7 +405,7 @@
> > >
> > > };
> > >
> > > i2s0: i2s@03830000 {
> > >
> > > - compatible = "samsung,i2s-v5";
> > > + compatible = "samsung,s5pv210-i2s";
> >
> > Device tree reviewers, this is something to look out for in the
> > future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
> > others "samsung,<ip>-<chip>". I don't personally care much one way or
> > another, but it really should be consistent.
>
> Hmm...I think, if "samsung,<ip name>-<ip version>" is possible, it would
> be nice. I remember there are no versions in datasheet for some IPs but
> something have like i2s and mfc. So "samsung,<ip>-<version>" is used
> for only i2s and mfc. But actually there are versions for Samsung IPs,
> no comments for that in datasheet. So I think, if Samsung can provide
> the specific version of Samsung IPs, we can use that like other
> platforms. I will prepare some table for that after meeting with
> Samsung hardware IP team so that samsung platform use one format
> "samsung,<ip>-<version>". Sorry, I don't think this is a good idea, unless you can force the IP team
to release a version table containing version of _every_ IP for _every_
released SoC, including those historical ones, like S3C24xx and S3C64xx.
Of course such tables should be available publicly. In addition, there might be other funny things going on with IPs and their
surroundings, that could make a need to create several separate compatible
values for the same IP revision, but on different SoCs, because it was
integrated in a slightly different way. I believe we have choses the "samsung,<chip>-<ip>" scheme to avoid being
dependent upon data that is not always publicly available, which is more
future- (and past-) proof and also solves the integration problem. Best regards,
Tomasz
Mark BrownAug. 16, 2013, 9:59 a.m. UTC | #5
On Fri, Aug 16, 2013 at 09:53:23AM +0200, Tomasz Figa wrote: > Sorry, I don't think this is a good idea, unless you can force the IP team
> to release a version table containing version of _every_ IP for _every_
> released SoC, including those historical ones, like S3C24xx and S3C64xx.
> Of course such tables should be available publicly. I don't think public availability is much of an issue here, the
datasheets are all NDAed anyway.
Mark BrownAug. 16, 2013, 10:06 a.m. UTC | #6
On Fri, Aug 16, 2013 at 09:56:18AM +0530, Padmavathi Venna wrote:
> This patch removes quirks from i2s node and change the i2s
> compatible names. Applied, thanks.
Kim KukjinAug. 18, 2013, 6:05 p.m. UTC | #7
On 08/16/13 16:53, Tomasz Figa wrote:
> Hi Kukjin,
>
[...] >>>> - compatible = "samsung,i2s-v5";
>>>> + compatible = "samsung,s5pv210-i2s";
>>>
>>> Device tree reviewers, this is something to look out for in the
>>> future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
>>> others "samsung,<ip>-<chip>". I don't personally care much one way or
>>> another, but it really should be consistent.
>>
>> Hmm...I think, if "samsung,<ip name>-<ip version>" is possible, it would
>> be nice. I remember there are no versions in datasheet for some IPs but
>> something have like i2s and mfc. So "samsung,<ip>-<version>" is used
>> for only i2s and mfc. But actually there are versions for Samsung IPs,
>> no comments for that in datasheet. So I think, if Samsung can provide
>> the specific version of Samsung IPs, we can use that like other
>> platforms. I will prepare some table for that after meeting with
>> Samsung hardware IP team so that samsung platform use one format
>> "samsung,<ip>-<version>".
>
> Sorry, I don't think this is a good idea, unless you can force the IP team
> to release a version table containing version of _every_ IP for _every_
> released SoC, including those historical ones, like S3C24xx and S3C64xx.
> Of course such tables should be available publicly.
>
It's different issue and I agree with Mark Brown's comments. > In addition, there might be other funny things going on with IPs and their
> surroundings, that could make a need to create several separate compatible
> values for the same IP revision, but on different SoCs, because it was
> integrated in a slightly different way.
>
> I believe we have choses the "samsung,<chip>-<ip>" scheme to avoid being
> dependent upon data that is not always publicly available, which is more
> future- (and past-) proof and also solves the integration problem.
>
Well, I don't think so, because Samsung is no more just SoC vendor.
Actually Samsung is providing just IP to customers, I think, they don't
like to use the name, exynos**** for their SoC or Chip, because exynos,
s3c or s5p whatever is Samsung's SoC brand name. If so, I think, my
suggestion is more reasonable. See the example of Synopsys and ARM
primecell...that's why I will try to do it. But I know I need to get
agreement from DT guys and maybe I need more time than I expect ;-) Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
}; i2s0: i2s@03830000 {
- compatible = "samsung,i2s-v5";
+ compatible = "samsung,s5pv210-i2s";
reg = <0x03830000 0x100>;
dmas = <&pdma0 10
&pdma0 9
@@ -415,16 +415,13 @@
<&clock_audss EXYNOS_I2S_BUS>,
<&clock_audss EXYNOS_SCLK_I2S>;
clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
- samsung,supports-6ch;
- samsung,supports-rstclr;
- samsung,supports-secdai;
samsung,idma-addr = <0x03000000>;
pinctrl-names = "default";
pinctrl-0 = <&i2s0_bus>;
}; i2s1: i2s@12D60000 {
- compatible = "samsung,i2s-v5";
+ compatible = "samsung,s3c6410-i2s";
reg = <0x12D60000 0x100>;
dmas = <&pdma1 12
&pdma1 11>;
@@ -436,7 +433,7 @@
}; i2s2: i2s@12D70000 {
- compatible = "samsung,i2s-v5";
+ compatible = "samsung,s3c6410-i2s";
reg = <0x12D70000 0x100>;
dmas = <&pdma0 12
&pdma0 11>;
[V5] ARM: dts: Change i2s compatible string on exynos5250【转】的更多相关文章
- Change value of string array at debug eclipse--转
Question: I have an application, but to test something, I need to change value of a String[]. But wh ...
- 内核添加dts后，device和device_driver的match匹配的变动：通过compatible属性进行匹配【转】
本文转载自:http://blog.csdn.net/ruanjianruanjianruan/article/details/61622053 内核添加dts后,device和device_driv ...
- Device Tree Usage( DTS文件语法)
http://elinux.org/Device_Tree_Usage Device Tree Usage Top Device Tree page This page walks throu ...
- Device Tree Usage(理解DTS文件语法)
Basic Data Format The device tree is a simple tree structure of nodes and properties. Properties are ...
- ARM Linux 3.x的设备树(Device Tree)
1. ARM Device Tree起源 Linus Torvalds在2011年3月17日的ARM Linux邮件列表宣称“this whole ARM thing is a f*cking pai ...
- ARM设备树
学习目标:学习设备树相关内容: 一.概念 在Linux 2.6中,ARM架构的板极硬件细节过多地被硬编码在arch/arm/plat-xxx和arch/arm/mach-xxx,在kernel中存在大 ...
- 《linux设备驱动开发详解》笔记——18 ARM linux设备树
18.1 设备树的起源 linux 2.6及之前,大量板级信息被硬编码到内核里,十分庞大,大量冗余代码: linux 2.6之前,引入了设备树: 设备树源于OpenFirmware,描述硬件的数据结构 ...
- Oracle CDC (Change Data Capture)更新数据捕获——Asynchronous HotLog Mode（附带简单的kettle任务实现数据同步）
Performing Asynchronous HotLog Publishing Step 1 Source Database DBA: Set the database initializat ...
- DTS
一.DTS的加载过程 如果要使用Device Tree,首先用户要了解自己的硬件配置和系统运行参数,并把这些信息组织成Device Tree source file.通过DTC(Device Tr ...
随机推荐
- Navicat Premium12激活教程
如果本文对你有用,请爱心点个赞,提高排名,帮助更多的人.谢谢大家!❤ 如果解决不了,可以在文末进群交流. 先到官网下载Navicat,然后安装(怎么安装就不阐述了). 然后,到Github上下载作者发 ...
- Mac 修改hostname
mac终端上输入命令: sudo scutil --set HostName newname # 实例 sudo scutil --set HostName master
- MySQL Transaction--网络丢包导致长时间未提交事务
TCP三次握手(Three-Way Handshake) 建立一个TCP连接时,需要客户端和服务端总共发送3个包以确认连接的建立. TCP三次握手:第一次握手:Client将标志位SYN置为1,随机产 ...
- 学习python的日常3
python的一些高级特性: 切片(跟名字一样,把一个完整的东西选取一部分自己想要的去切下来):通过切片可以快速的去除一些元素,只要确定好索引位置,避免的循环导致的多写代码 数组,元组,字符串都可以用 ...
- 7. Input and Output
7. Input and Output There are several ways to present the output of a program; data can be printed i ...
- 如何设置CentOS 7获取动态IP和静态IP
自动获取动态IP地址 1.输入“ip addr”并按回车键确定,发现无法获取IP(CentOS 7默认没有ifconfig命令),记录下网卡名称(本例中为ens33). 2.输入“cd /etc/sy ...
- Mysql 查询当天、昨天、近7天、一周内、本月、上一月等的数据（函数执行日期的算术运算）
注:where语句后中的字段last_login_time 替换成 时间字段名 即可 #查询昨天登录用户的账号 ; #查询当天登录用户的账号 ; #查询所有last_login_time值在最后1天内 ...
- Linux命令基础4-cat命令
cat命令连接文件并打印到标准输出设备上,cat经常用来显示文件的内容,类似于下的type命令. 注意:当文件较大时,文本在屏幕上迅速闪过(滚屏),用户往往看不清所显示的内容.因此,一般用more等命 ...
- centos 环境下安装maven
安装Maven Maven的下载地址:http://maven.apache.org/download.cgi这里以最新的3.2.3版本为例进行安装,在这之前需要确保机器上已经安装了JDK. 首先下载 ...
- linux学习7 Linux文件系统功能和作用详解
一.终端 1.用户界面 GUI: GNome KDE CLI: bash,zsh,sh,csh,tcsh,ksh 2.远程连接 a.ssh协议. 查看系统是否监听于tcp协议的22号端口: ss - ...