[V5] ARM: dts: Change i2s compatible string on exynos5250【转】
本文转载自:https://patchwork.kernel.org/patch/2845464/
This patch removes quirks from i2s node and change the i2s
compatible names. Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
--- Changes since V4:
- Mark Brown reverted the below two patches due to below build failure with
exynos_defconfig.
"ARM: dts: exynos5250: move common i2s properties to exynos5 dtsi"
"ARM: dts: Change i2s compatible string on exynos5250" build error:
DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
ERROR (phandle_references): Reference to non-existent node or label "pdma1"
ERROR (phandle_references): Reference to non-existent node or label "pdma1"
ERROR (phandle_references): Reference to non-existent node or label "pdma0"
ERROR (phandle_references): Reference to non-existent node or label "pdma0" But with out "ARM: dts: Change i2s compatible string on exynos5250" will break the i2s
driver. So posting this patch now and will take care of posting other patch later after dependent
patches got merged. arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
Comments
On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna <padma.v@samsung.com> wrote:
> This patch removes quirks from i2s node and change the i2s
> compatible names.
>
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> ---
>
> Changes since V4:
> - Mark Brown reverted the below two patches due to below build failure with
> exynos_defconfig.
> "ARM: dts: exynos5250: move common i2s properties to exynos5 dtsi"
> "ARM: dts: Change i2s compatible string on exynos5250"
>
> build error:
> DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
> ERROR (phandle_references): Reference to non-existent node or label "pdma1"
> ERROR (phandle_references): Reference to non-existent node or label "pdma1"
> ERROR (phandle_references): Reference to non-existent node or label "pdma0"
> ERROR (phandle_references): Reference to non-existent node or label "pdma0"
>
> But with out "ARM: dts: Change i2s compatible string on exynos5250" will break the i2s
> driver.
>
> So posting this patch now and will take care of posting other patch later after dependent
> patches got merged.
>
> arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index ef57277..376090f 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -405,7 +405,7 @@
> };
>
> i2s0: i2s@03830000 {
> - compatible = "samsung,i2s-v5";
> + compatible = "samsung,s5pv210-i2s"; Device tree reviewers, this is something to look out for in the
future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
others "samsung,<ip>-<chip>". I don't personally care much one way or
another, but it really should be consistent. -Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Olof Johansson wrote:
>
> On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna <padma.v@samsung.com>
> wrote:
> > This patch removes quirks from i2s node and change the i2s
> > compatible names.
> >
> > Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> > ---
> >
> > Changes since V4:
> > - Mark Brown reverted the below two patches due to below build
> failure with
> > exynos_defconfig.
> > "ARM: dts: exynos5250: move common i2s properties to
exynos5
> dtsi"
> > "ARM: dts: Change i2s compatible string on exynos5250"
> >
> > build error:
> > DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
> > ERROR (phandle_references): Reference to non-existent node or
> label "pdma1"
> > ERROR (phandle_references): Reference to non-existent node or
> label "pdma1"
> > ERROR (phandle_references): Reference to non-existent node or
> label "pdma0"
> > ERROR (phandle_references): Reference to non-existent node or
> label "pdma0"
> >
> > But with out "ARM: dts: Change i2s compatible string on exynos5250" will
> break the i2s
> > driver.
> >
> > So posting this patch now and will take care of posting other patch
> later after dependent
> > patches got merged.
> >
> > arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
> > 1 files changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> > index ef57277..376090f 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -405,7 +405,7 @@
> > };
> >
> > i2s0: i2s@03830000 {
> > - compatible = "samsung,i2s-v5";
> > + compatible = "samsung,s5pv210-i2s";
>
> Device tree reviewers, this is something to look out for in the
> future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
> others "samsung,<ip>-<chip>". I don't personally care much one way or
> another, but it really should be consistent.
>
Hmm...I think, if "samsung,<ip name>-<ip version>" is possible, it would be
nice. I remember there are no versions in datasheet for some IPs but
something have like i2s and mfc. So "samsung,<ip>-<version>" is used for
only i2s and mfc. But actually there are versions for Samsung IPs, no
comments for that in datasheet. So I think, if Samsung can provide the
specific version of Samsung IPs, we can use that like other platforms. I
will prepare some table for that after meeting with Samsung hardware IP team
so that samsung platform use one format "samsung,<ip>-<version>". Thanks,
Kukjin --
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Olof, On Thursday 15 of August 2013 21:48:32 Olof Johansson wrote:
> On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna <padma.v@samsung.com>
wrote:
> > This patch removes quirks from i2s node and change the i2s
> > compatible names.
> >
> > Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> > ---
> >
> > Changes since V4:
> > - Mark Brown reverted the below two patches due to below build
> > failure with>
> > exynos_defconfig.
> >
> > "ARM: dts: exynos5250: move common i2s properties to
> > exynos5 dtsi"
> > "ARM: dts: Change i2s compatible string on exynos5250"
> >
> > build error:
> > DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
> > ERROR (phandle_references): Reference to non-existent node
> > or label "pdma1" ERROR (phandle_references): Reference to
> > non-existent node or label "pdma1" ERROR
> > (phandle_references): Reference to non-existent node or
> > label "pdma0" ERROR (phandle_references): Reference to
> > non-existent node or label "pdma0">
> > But with out "ARM: dts: Change i2s compatible string on exynos5250"
> > will break the i2s driver.
> >
> > So posting this patch now and will take care of posting other patch
> > later after dependent patches got merged.
> >
> > arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
> > 1 files changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > b/arch/arm/boot/dts/exynos5250.dtsi index ef57277..376090f 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -405,7 +405,7 @@
> >
> > };
> >
> > i2s0: i2s@03830000 {
> >
> > - compatible = "samsung,i2s-v5";
> > + compatible = "samsung,s5pv210-i2s";
>
> Device tree reviewers, this is something to look out for in the
> future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
> others "samsung,<ip>-<chip>". I don't personally care much one way or
> another, but it really should be consistent. Hmm, I just did a quick git grep over arch/arm/boot/dts and could not
really find the "samsung,<ip>-<chip>" pattern. Except MFC (and without Padma's patch also I2S), which used "samsung,<ip>-
<ip version>, all the compatible values I can see are based on
"samsung,<chip>-<ip>" pattern. I believe we discussed this issue several times already and finally agreed
to use "samsung,<chip>-<ip>" for any new compatible values. Best regards,
Tomasz
Hi Kukjin, On Friday 16 of August 2013 14:43:17 Kukjin Kim wrote:
> Olof Johansson wrote:
> > On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna
> > <padma.v@samsung.com>
> >
> > wrote:
> > > This patch removes quirks from i2s node and change the i2s
> > > compatible names.
> > >
> > > Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> > > ---
> > >
> > > Changes since V4:
> > > - Mark Brown reverted the below two patches due to below
> > > build
> >
> > failure with
> >
> > > exynos_defconfig.
> > >
> > > "ARM: dts: exynos5250: move common i2s properties to
>
> exynos5
>
> > dtsi"
> >
> > > "ARM: dts: Change i2s compatible string on
> > > exynos5250"
> > >
> > > build error:
> > > DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
> > > ERROR (phandle_references): Reference to non-existent node
> > > or
> >
> > label "pdma1"
> >
> > > ERROR (phandle_references): Reference to non-existent node
> > > or
> >
> > label "pdma1"
> >
> > > ERROR (phandle_references): Reference to non-existent node
> > > or
> >
> > label "pdma0"
> >
> > > ERROR (phandle_references): Reference to non-existent node
> > > or
> >
> > label "pdma0"
> >
> > > But with out "ARM: dts: Change i2s compatible string on exynos5250"
> > > will>
> > break the i2s
> >
> > > driver.
> > >
> > > So posting this patch now and will take care of posting other patch
> >
> > later after dependent
> >
> > > patches got merged.
> > >
> > > arch/arm/boot/dts/exynos5250.dtsi | 9 +++------
> > > 1 files changed, 3 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> >
> > b/arch/arm/boot/dts/exynos5250.dtsi
> >
> > > index ef57277..376090f 100644
> > > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > > @@ -405,7 +405,7 @@
> > >
> > > };
> > >
> > > i2s0: i2s@03830000 {
> > >
> > > - compatible = "samsung,i2s-v5";
> > > + compatible = "samsung,s5pv210-i2s";
> >
> > Device tree reviewers, this is something to look out for in the
> > future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
> > others "samsung,<ip>-<chip>". I don't personally care much one way or
> > another, but it really should be consistent.
>
> Hmm...I think, if "samsung,<ip name>-<ip version>" is possible, it would
> be nice. I remember there are no versions in datasheet for some IPs but
> something have like i2s and mfc. So "samsung,<ip>-<version>" is used
> for only i2s and mfc. But actually there are versions for Samsung IPs,
> no comments for that in datasheet. So I think, if Samsung can provide
> the specific version of Samsung IPs, we can use that like other
> platforms. I will prepare some table for that after meeting with
> Samsung hardware IP team so that samsung platform use one format
> "samsung,<ip>-<version>". Sorry, I don't think this is a good idea, unless you can force the IP team
to release a version table containing version of _every_ IP for _every_
released SoC, including those historical ones, like S3C24xx and S3C64xx.
Of course such tables should be available publicly. In addition, there might be other funny things going on with IPs and their
surroundings, that could make a need to create several separate compatible
values for the same IP revision, but on different SoCs, because it was
integrated in a slightly different way. I believe we have choses the "samsung,<chip>-<ip>" scheme to avoid being
dependent upon data that is not always publicly available, which is more
future- (and past-) proof and also solves the integration problem. Best regards,
Tomasz
On Fri, Aug 16, 2013 at 09:53:23AM +0200, Tomasz Figa wrote: > Sorry, I don't think this is a good idea, unless you can force the IP team
> to release a version table containing version of _every_ IP for _every_
> released SoC, including those historical ones, like S3C24xx and S3C64xx.
> Of course such tables should be available publicly. I don't think public availability is much of an issue here, the
datasheets are all NDAed anyway.
On Fri, Aug 16, 2013 at 09:56:18AM +0530, Padmavathi Venna wrote:
> This patch removes quirks from i2s node and change the i2s
> compatible names. Applied, thanks.
On 08/16/13 16:53, Tomasz Figa wrote:
> Hi Kukjin,
>
[...] >>>> - compatible = "samsung,i2s-v5";
>>>> + compatible = "samsung,s5pv210-i2s";
>>>
>>> Device tree reviewers, this is something to look out for in the
>>> future. Some samsung platforms/drivers use "samsung,<chip>-<ip>",
>>> others "samsung,<ip>-<chip>". I don't personally care much one way or
>>> another, but it really should be consistent.
>>
>> Hmm...I think, if "samsung,<ip name>-<ip version>" is possible, it would
>> be nice. I remember there are no versions in datasheet for some IPs but
>> something have like i2s and mfc. So "samsung,<ip>-<version>" is used
>> for only i2s and mfc. But actually there are versions for Samsung IPs,
>> no comments for that in datasheet. So I think, if Samsung can provide
>> the specific version of Samsung IPs, we can use that like other
>> platforms. I will prepare some table for that after meeting with
>> Samsung hardware IP team so that samsung platform use one format
>> "samsung,<ip>-<version>".
>
> Sorry, I don't think this is a good idea, unless you can force the IP team
> to release a version table containing version of _every_ IP for _every_
> released SoC, including those historical ones, like S3C24xx and S3C64xx.
> Of course such tables should be available publicly.
>
It's different issue and I agree with Mark Brown's comments. > In addition, there might be other funny things going on with IPs and their
> surroundings, that could make a need to create several separate compatible
> values for the same IP revision, but on different SoCs, because it was
> integrated in a slightly different way.
>
> I believe we have choses the "samsung,<chip>-<ip>" scheme to avoid being
> dependent upon data that is not always publicly available, which is more
> future- (and past-) proof and also solves the integration problem.
>
Well, I don't think so, because Samsung is no more just SoC vendor.
Actually Samsung is providing just IP to customers, I think, they don't
like to use the name, exynos**** for their SoC or Chip, because exynos,
s3c or s5p whatever is Samsung's SoC brand name. If so, I think, my
suggestion is more reasonable. See the example of Synopsys and ARM
primecell...that's why I will try to do it. But I know I need to get
agreement from DT guys and maybe I need more time than I expect ;-) Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
}; i2s0: i2s@03830000 {
- compatible = "samsung,i2s-v5";
+ compatible = "samsung,s5pv210-i2s";
reg = <0x03830000 0x100>;
dmas = <&pdma0 10
&pdma0 9
@@ -415,16 +415,13 @@
<&clock_audss EXYNOS_I2S_BUS>,
<&clock_audss EXYNOS_SCLK_I2S>;
clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
- samsung,supports-6ch;
- samsung,supports-rstclr;
- samsung,supports-secdai;
samsung,idma-addr = <0x03000000>;
pinctrl-names = "default";
pinctrl-0 = <&i2s0_bus>;
}; i2s1: i2s@12D60000 {
- compatible = "samsung,i2s-v5";
+ compatible = "samsung,s3c6410-i2s";
reg = <0x12D60000 0x100>;
dmas = <&pdma1 12
&pdma1 11>;
@@ -436,7 +433,7 @@
}; i2s2: i2s@12D70000 {
- compatible = "samsung,i2s-v5";
+ compatible = "samsung,s3c6410-i2s";
reg = <0x12D70000 0x100>;
dmas = <&pdma0 12
&pdma0 11>;
[V5] ARM: dts: Change i2s compatible string on exynos5250【转】的更多相关文章
- Change value of string array at debug eclipse--转
Question: I have an application, but to test something, I need to change value of a String[]. But wh ...
- 内核添加dts后,device和device_driver的match匹配的变动:通过compatible属性进行匹配【转】
本文转载自:http://blog.csdn.net/ruanjianruanjianruan/article/details/61622053 内核添加dts后,device和device_driv ...
- Device Tree Usage( DTS文件语法)
http://elinux.org/Device_Tree_Usage Device Tree Usage Top Device Tree page This page walks throu ...
- Device Tree Usage(理解DTS文件语法)
Basic Data Format The device tree is a simple tree structure of nodes and properties. Properties are ...
- ARM Linux 3.x的设备树(Device Tree)
1. ARM Device Tree起源 Linus Torvalds在2011年3月17日的ARM Linux邮件列表宣称“this whole ARM thing is a f*cking pai ...
- ARM设备树
学习目标:学习设备树相关内容: 一.概念 在Linux 2.6中,ARM架构的板极硬件细节过多地被硬编码在arch/arm/plat-xxx和arch/arm/mach-xxx,在kernel中存在大 ...
- 《linux设备驱动开发详解》笔记——18 ARM linux设备树
18.1 设备树的起源 linux 2.6及之前,大量板级信息被硬编码到内核里,十分庞大,大量冗余代码: linux 2.6之前,引入了设备树: 设备树源于OpenFirmware,描述硬件的数据结构 ...
- Oracle CDC (Change Data Capture)更新数据捕获——Asynchronous HotLog Mode(附带简单的kettle任务实现数据同步)
Performing Asynchronous HotLog Publishing Step 1 Source Database DBA: Set the database initializat ...
- DTS
一.DTS的加载过程 如果要使用Device Tree,首先用户要了解自己的硬件配置和系统运行参数,并把这些信息组织成Device Tree source file.通过DTC(Device Tr ...
随机推荐
- 无法将文件“E:\NetWorkPace\Permission\packages\EntityFramework.6.1.1\lib\net45\EntityFramework.xml”复制到“bin\EntityFramework.xml”。对路径“bin\EntityFramework.xml”的访问被拒绝。
无法将文件“E:\NetWorkPace\Permission\packages\EntityFramework.6.1.1\lib\net45\EntityFramework.xml”复制到“bin ...
- python(time/random模块)
一.Time模块 1.时间戳 时间戳是指格林威治时间1970年01月01日00时00分00秒(北京时间1970年01月01日08时00分00秒)起至现在的总秒数 最早出现的UNIX操作系统考虑到计算机 ...
- WampServer详解
php能做什么,它是运行在服务器端的,web网站大部分数据都是存储在服务器上的,PHP就是用来处理这些存储在服务器的数据.跨平台,服务器可以是多种平台上的服务器,脚本语言,免费. wampserver ...
- Exchange 退信550 5.1.11 RESOLVER.ADR.ExRecipNotFound
问题描述: 在Exchange 2013环境下,某客户将一个用户的邮箱test@abc.com禁用,过了几天又想连接该邮箱,但是却没有找到禁用的邮箱,然后客户就Enable-MailBox重新创建了一 ...
- Locust 教程
写在 Locust 教程开始的前面 本文参考了: Locust 教程 : https://www.axihe.com/tools/locust/home.html : locust 的官方 Githu ...
- 阿里巴巴开源性能监控神器Arthas jvm
原文:https://www.cnblogs.com/testfan2019/p/11038791.html 如果问性能测试中最难的是哪部分,相信很多人会说“性能调优”.确实是这样,性能调优是一个非常 ...
- 搭建cas 服务器
https://blog.csdn.net/oumuv/article/details/84306361 记得添加数据库驱动 https://blog.csdn.net/zhouzhiwengang/ ...
- 渗透之路基础 -- XXE注入漏洞
XXE漏洞 XXE漏洞全称XML External Entity Injection即xml外部实体注入漏洞,XXE漏洞发生在应用程序解析XML输入时,没有禁止外部实体的加载,导致可加载恶意外部文件, ...
- Problem G: STL——整理唱片(list的使用)
#include<iostream> #include<list> #include<iterator> #include<algorithm> usi ...
- 麻雀虽小,五脏俱全。基于Asp.net core + Sqlite 5分钟快速上手一个小项目
虽然该方法不会用在实际开发中,但该过程对于初学者还是非常友好的,真应了麻雀虽小,五脏俱全这句话了.好了不多废话了,直接开始!! 1.建立一个名为test的Asp.net core web应用程序 这一 ...