if else重复十多次的业务代码也是醉了
嗯,一个页面同时刷这8个接口,我说能不能合并到一个网络接口,不用一个页面并发8个请求,他说太长了,不好合并。
我看了一下他代码,也是醉了,写了8个接口,访问的都是一个表,然后每个接口重复if else十多次。
先看看修改的差别:
修改之后:
附上其中一个接口:
- //移民生活
- public function immiLiving()
- {
- $cid = $_POST['cid'];
- $db = M('infolist');
- if($cid == 1){
- $data['classid'] = '183';
- $data['mainid'] = '2';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 2){
- $data['classid'] = '183';
- $data['mainid'] = '3';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 3){
- $data['classid'] = '183';
- $data['mainid'] = '4';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 5){
- $data['classid'] = '183';
- $data['mainid'] = '8';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 6){
- $data['classid'] = '183';
- $data['mainid'] = '6';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 7){
- $data['classid'] = '183';
- $data['mainid'] = '9';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 8){
- $data['classid'] = '183';
- $data['mainid'] = '11';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 9){
- $data['classid'] = '183';
- $data['mainid'] = '5';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 10){
- $data['classid'] = '183';
- $data['mainid'] = '10';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 11){
- $data['classid'] = '183';
- $data['mainid'] = '22';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 12){
- $data['classid'] = '183';
- $data['mainid'] = '7';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 15){
- $data['classid'] = '183';
- $data['mainid'] = '19';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 16){
- $data['classid'] = '183';
- $data['mainid'] = '21';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 22){
- $data['classid'] = '183';
- $data['mainid'] = '29';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }elseif($cid == 23){
- $data['classid'] = '183';
- $data['mainid'] = '18';
- $data['delstate'] = '';
- $data['checkinfo'] = true;
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- if($insurance){
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['data'] = $insurance;
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }
- }
类似的还有好几个,修正一下如下:
- //生活百科
- public function life()
- {
- $cid = $_POST['cid'];
- $db = M('infolist');
- //生活百科
- $arr1 = array('1'=>array('classid'=>'180','mainid'=>'2'),
- '2'=>array('classid'=>'180','mainid'=>'3'),
- '3'=>array('classid'=>'180','mainid'=>'4'),
- '5'=>array('classid'=>'180','mainid'=>'8'),
- '6'=>array('classid'=>'180','mainid'=>'6'),
- '7'=>array('classid'=>'180','mainid'=>'9'),
- '8'=>array('classid'=>'180','mainid'=>'11'),
- '9'=>array('classid'=>'180','mainid'=>'5'),
- '10'=>array('classid'=>'180','mainid'=>'10'),
- '11'=>array('classid'=>'180','mainid'=>'22'),
- '12'=>array('classid'=>'180','mainid'=>'7'),
- '15'=>array('classid'=>'180','mainid'=>'19'),
- '16'=>array('classid'=>'180','mainid'=>'21'),
- '22'=>array('classid'=>'180','mainid'=>'29'),
- '23'=>array('classid'=>'180','mainid'=>'18'));
- //移民生活
- $arr3 = array('1'=>array('classid'=>'183','mainid'=>'2'),
- '2'=>array('classid'=>'183','mainid'=>'3'),
- '3'=>array('classid'=>'183','mainid'=>'4'),
- '5'=>array('classid'=>'183','mainid'=>'8'),
- '6'=>array('classid'=>'183','mainid'=>'6'),
- '7'=>array('classid'=>'183','mainid'=>'9'),
- '8'=>array('classid'=>'183','mainid'=>'11'),
- '9'=>array('classid'=>'183','mainid'=>'5'),
- '10'=>array('classid'=>'183','mainid'=>'10'),
- '11'=>array('classid'=>'183','mainid'=>'22'),
- '12'=>array('classid'=>'183','mainid'=>'7'),
- '15'=>array('classid'=>'183','mainid'=>'19'),
- '16'=>array('classid'=>'183','mainid'=>'21'),
- '22'=>array('classid'=>'183','mainid'=>'29'),
- '23'=>array('classid'=>'183','mainid'=>'18'));
- //当地教育
- $arr4 = array('1'=>array('classid'=>'181','mainid'=>'2'),
- '2'=>array('classid'=>'181','mainid'=>'3'),
- '3'=>array('classid'=>'181','mainid'=>'4'),
- '5'=>array('classid'=>'181','mainid'=>'8'),
- '6'=>array('classid'=>'181','mainid'=>'6'),
- '7'=>array('classid'=>'181','mainid'=>'9'),
- '8'=>array('classid'=>'181','mainid'=>'11'),
- '9'=>array('classid'=>'181','mainid'=>'5'),
- '10'=>array('classid'=>'181','mainid'=>'10'),
- '11'=>array('classid'=>'181','mainid'=>'22'),
- '12'=>array('classid'=>'181','mainid'=>'7'),
- '15'=>array('classid'=>'181','mainid'=>'19'),
- '16'=>array('classid'=>'181','mainid'=>'21'),
- '22'=>array('classid'=>'181','mainid'=>'29'),
- '23'=>array('classid'=>'181','mainid'=>'18'));
- //移民政策
- $arr5 = array('1'=>array('classid'=>'182','mainid'=>'2'),
- '2'=>array('classid'=>'182','mainid'=>'3'),
- '3'=>array('classid'=>'182','mainid'=>'4'),
- '5'=>array('classid'=>'182','mainid'=>'8'),
- '6'=>array('classid'=>'182','mainid'=>'6'),
- '7'=>array('classid'=>'182','mainid'=>'9'),
- '8'=>array('classid'=>'182','mainid'=>'11'),
- '9'=>array('classid'=>'182','mainid'=>'5'),
- '10'=>array('classid'=>'182','mainid'=>'10'),
- '11'=>array('classid'=>'182','mainid'=>'22'),
- '12'=>array('classid'=>'182','mainid'=>'7'),
- '15'=>array('classid'=>'182','mainid'=>'19'),
- '16'=>array('classid'=>'182','mainid'=>'21'),
- '22'=>array('classid'=>'182','mainid'=>'29'),
- '23'=>array('classid'=>'182','mainid'=>'18'));
- //税收福利
- $arr6 = array('1'=>array('classid'=>'184','mainid'=>'2'),
- '2'=>array('classid'=>'184','mainid'=>'3'),
- '3'=>array('classid'=>'184','mainid'=>'4'),
- '5'=>array('classid'=>'184','mainid'=>'8'),
- '6'=>array('classid'=>'184','mainid'=>'6'),
- '7'=>array('classid'=>'184','mainid'=>'9'),
- '8'=>array('classid'=>'184','mainid'=>'11'),
- '9'=>array('classid'=>'184','mainid'=>'5'),
- '10'=>array('classid'=>'184','mainid'=>'10'),
- '11'=>array('classid'=>'184','mainid'=>'22'),
- '12'=>array('classid'=>'184','mainid'=>'7'),
- '15'=>array('classid'=>'184','mainid'=>'19'),
- '16'=>array('classid'=>'184','mainid'=>'21'),
- '22'=>array('classid'=>'184','mainid'=>'29'),
- '23'=>array('classid'=>'184','mainid'=>'18'));
- //常见问题
- $arr7 = array('1'=>array('classid'=>'43','mainid'=>'2'),
- '2'=>array('classid'=>'43','mainid'=>'2'), //原函数这里是2,不是3
- '3'=>array('classid'=>'43','mainid'=>'4'),
- '5'=>array('classid'=>'43','mainid'=>'8'),
- '6'=>array('classid'=>'43','mainid'=>'6'),
- '7'=>array('classid'=>'43','mainid'=>'9'),
- '8'=>array('classid'=>'43','mainid'=>'11'),
- '9'=>array('classid'=>'43','mainid'=>'5'),
- '10'=>array('classid'=>'43','mainid'=>'10'),
- '11'=>array('classid'=>'43','mainid'=>'22'),
- '12'=>array('classid'=>'43','mainid'=>'7'),
- '15'=>array('classid'=>'43','mainid'=>'19'),
- '16'=>array('classid'=>'43','mainid'=>'21'),
- '22'=>array('classid'=>'43','mainid'=>'29'),
- '23'=>array('classid'=>'43','mainid'=>'18'));
- //where
- $data['delstate'] = $val['dekstate'];
- $data['checkinfo'] = $val['checkinfo'];
- //生活百科
- foreach($arr1 as $key => $val){
- if($key == $cid){
- //取数组里面的参数
- $data['classid'] = $val['classid'];
- $data['mainid'] = $val['mainid'];
- $life = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- break;
- }
- }
- //移民生活
- foreach($arr3 as $key => $val){
- if($key == $cid){
- //取数组里面的参数
- $data['classid'] = $val['classid'];
- $data['mainid'] = $val['mainid'];
- $immiLiving = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- break;
- }
- }
- //当地教育
- foreach($arr4 as $key => $val){
- if($key == $cid){
- //取数组里面的参数
- $data['classid'] = $val['classid'];
- $data['mainid'] = $val['mainid'];
- $localEducation = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- break;
- }
- }
- //移民政策
- foreach($arr5 as $key => $val){
- if($key == $cid){
- //取数组里面的参数
- $data['classid'] = $val['classid'];
- $data['mainid'] = $val['mainid'];
- $immiPolicy = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- break;
- }
- }
- //税收福利
- foreach($arr6 as $key => $val){
- if($key == $cid){
- //取数组里面的参数
- $data['classid'] = $val['classid'];
- $data['mainid'] = $val['mainid'];
- $taxBenefits = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- break;
- }
- }
- //常见问题
- foreach($arr7 as $key => $val){
- if($key == $cid){
- //取数组里面的参数
- $data['classid'] = $val['classid'];
- $data['mainid'] = $val['mainid'];
- $commProblems = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- break;
- }
- }
- if($cid == 1){
- //保险咨询
- $data['classid'] = '53';
- $data['mainid'] = '2';
- $insurance = $db->field('id,title,classid,posttime,linkurl')->where($data)->order('orderid desc')->limit(4)->select();
- //文件下载
- $db2 = M('soft');
- $data2['delstate'] = '';
- $data2['checkinfo'] = true;
- $download = $db2->field('id,title,classid,posttime,dlurl')->where($data2)->order('orderid desc')->limit(4)->select();
- }
- if($life)
- {
- $response['status'] = 'Y';
- $response['msg'] = '成功';
- $response['life'] = $life;
- $response['immiLiving'] = $immiLiving;
- $response['localEducation'] = $localEducation;
- $response['immiPolicy'] = $immiPolicy;
- $response['taxBenefits'] = $taxBenefits;
- $response['commProblems'] = $commProblems;
- if($cid==1){
- $response['insurance'] = $insurance;
- $response['download'] = $download;
- }
- echo json_encode($response);
- }else{
- $response['status'] = 'N';
- $response['msg'] = '失败';
- echo json_encode($response);
- }
- }
if else重复十多次的业务代码也是醉了的更多相关文章
- 深信服模式(先做减法,必须拜访客户三次、研究需求方向,把产品的问题控制住,快速反应,在未来十年,绝大部分业务都会搬到Internet上来,实现All on Internet)good
深圳市盛凯信息科技有限公司与深信服合作多年,可以说是看着深信服“飞速”长大的.盛凯的总经理邓渊在采访中笑言:“他们(深信服)发展得太快,而我们发展得太慢.” 深信服的产品线已从最初只有VPN一条,到目 ...
- 朱晔的互联网架构实践心得S2E1:业务代码究竟难不难写?
注意,这是我的架构实践心得的第二季的系列文章,第一季有10篇你也可以回顾. 见https://www.cnblogs.com/lovecindywang/category/1296779.html 最 ...
- (原创)一步步优化业务代码之——从数据库获取DataTable并绑定到List<Class>
一,前言 现实业务当中,有一个很常见的流程:从数据库获取数据到DataTable,然后将DataTable绑定到实体类集合上,一般是List<Class>,代码写起来也简单:遍历+赋值就可 ...
- 唱吧DevOps的落地,微服务CI/CD的范本技术解读----最大的难点并不是实际业务代码的编写,而是服务的监控和调试以及容器的编排
1.业务架构:从单体式到微服务 K歌亭是唱吧的一条新业务线,旨在提供线下便捷的快餐式K歌方式,用户可以在一个电话亭大小的空间里完成K歌体验.K歌亭在客户端有VOD.微信和Web共三个交互入口,业务复杂 ...
- 朱晔的互联网架构实践心得S2E2:写业务代码最容易掉的10种坑
我承认,本文的标题有一点标题党,特别是写业务代码,大家因为没有足够重视一些细节最容易调的坑(侧重Java,当然,本文说的这些点很多是不限制于语言的). 1.客户端的使用 我们在使用Redis.Elas ...
- .netcore+vue+elementUI 前后端分离---支持前端、后台业务代码扩展的快速开发框架
框架采用.NetCore + Vue前后端分离,并且支持前端.后台代码业务动态扩展,框架内置了一套有着20多种属性配置的代码生成器,可灵活配置生成的代码,代码生成器界面配置完成即可生成单表(主表)的增 ...
- 读 Kafka 源码写优雅业务代码:配置类
这个 Kafka 的专题,我会从系统整体架构,设计到代码落地.和大家一起杠源码,学技巧,涨知识.希望大家持续关注一起见证成长! 我相信:技术的道路,十年如一日!十年磨一剑! 往期文章 Kafka 探险 ...
- 淘系工程师讲解的使用Spring特性优雅书写业务代码
使用Spring特性优雅书写业务代码 大家在日常业务开发工作中相信多多少少遇到过下面这样的几个场景: 当某一个特定事件或动作发生以后,需要执行很多联动动作,如果串行去执行的话太耗时,如果引入消息中 ...
- python3.4学习笔记(十四) 网络爬虫实例代码,抓取新浪爱彩双色球开奖数据实例
python3.4学习笔记(十四) 网络爬虫实例代码,抓取新浪爱彩双色球开奖数据实例 新浪爱彩双色球开奖数据URL:http://zst.aicai.com/ssq/openInfo/ 最终输出结果格 ...
随机推荐
- SDK,monkey 浅谈
最近在工作之余碰到一些手机测试的新手,现在测试手机的基本都是android的系统. 然后在遇到压力测试的时候就开始遇到问题了. 压力测试用什么工具?怎么使用?工具怎么来? 今天遇到两个人都问我SDK是 ...
- 我发现调用boostrap的弹框
在引用了boostrap.js和boostrap.css之后 本来boostrap是基于jQuery的.但是我们的项目里没有用jQuery,而是用的zepto. 调用boostrap的弹框有两种方式: ...
- HTTP请求响应对照表
1)请求(客户端->服务端[request]) GET(请求的方式) /books/java.html(请求的目标资源) HTTP/1.1(请求采用的协议和版本号) Accept: */*(客户 ...
- Win8 x64环境下VS2010 C#工程运行报错:没有注册类 (异常来自 HRESULT:0x80040154
来源:http://blog.sina.com.cn/s/blog_7095482001019c2v.html 问题描述: 在Win8 x64环境下,VS2010的C#工程中引用了COM组件(Acti ...
- PHP疑惑
<?php $a = array(); $a[0] = 1; $a[1] = 2; $b = (object)$a; var_dump($b); 怎么从对象$b 中取值??? <?php ...
- 基于注解的DWR使用
dwr3.0支持使用注解,如果不喜欢配置dwr.xml文件,注解是个不错的方法,简单快捷. 步骤如下: 1.配置web.xml文件,需要在DwrServlet里加classes初始化参数: <i ...
- 【转】Android studio 解决64K超出链接数限制问题
http://my.oschina.net/gabriel1215/blog/602608 目录[-] 使用MultiDex支持库 注意事项 结论 如果你是一个android开发者,你至少听说过的Da ...
- 数据库知识整理<六>
聚合函数与分组 6.1使用聚合函数进行数据统计: 聚合函数常见的有以下几种: count:返回该结果集中行的数目. sum:返回结果集中所有值的总和. avg:返回结果集中所有值的平均值. max:返 ...
- 编译生成.NET Core Framework遇到的问题
前两天在Windows Server 2012上编译生成.NET Core Framework的代码库corefx,遭遇了几个问题,在这篇博文中记录一下. 编译生成操作方法是在命令行(Develope ...
- Visual Studio 2013 新功能 Memory Dump 分析器
本文为 Dennis Gao 原创技术文章,发表于博客园博客,未经作者本人允许禁止任何形式的转载. TechEd2013 发现新功能 12月5日和6日,在国家会议中心参加了微软的 TechEd2013 ...